Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-12-08 16:11:28 +09:00
Code Issues Packages Projects Releases Wiki Activity

wallet2: warn instead of throw when RingDB doesn't include spend

Browse Source 
A reorg can end up causing an output's position in the chain to
move. Since the wallet doesn't update the RingDB on reorg, it
may refer to the output's stale position in the chain.

This seems a reasonable solution rather than introducing complex
logic to update the stale ring member's value on rerog, since
RingDB can be deprecated with FCMP++.
This commit is contained in:
j-berman 2025-09-17 15:21:46 -07:00
parent a440e91790
commit 1829992970
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/wallet/wallet2.cpp
View File

@ -9518,8 +9518,11 @@ void wallet2::get_outs(std::vector<std::vector<tools::wallet2::get_outs_entry>>
MINFO("Ignoring output " << out << ", too recent"); MINFO("Ignoring output " << out << ", too recent");
} }
} }
THROW_WALLET_EXCEPTION_IF(!own_found, error::wallet_internal_error, if (!own_found)
"Known ring does not include the spent output: " + std::to_string(td.m_global_output_index)); {
MWARNING("Known ring does not include the spent output: " + std::to_string(td.m_global_output_index)
+ ", there may have been a reorg that moved the spent output's position in the chain");
}
} }
} }