From 2820757d9d7ea7754e1c32b923eb164aa533c210 Mon Sep 17 00:00:00 2001 From: jeffro256 Date: Fri, 11 Jul 2025 11:31:41 -0500 Subject: [PATCH] common: remove tools::add_element Since C++17, `std::vector::emplace_back()` returns a reference, so this helper isn't needed anymore. --- src/common/container_helpers.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/common/container_helpers.h b/src/common/container_helpers.h index c42f65efb..45d29a42d 100644 --- a/src/common/container_helpers.h +++ b/src/common/container_helpers.h @@ -138,13 +138,6 @@ bool keys_match_internal_values(const std::unordered_map &map, Pre return true; } -/// convenience wrapper for getting the last element after emplacing back -template -typename ContainerT::value_type& add_element(ContainerT &container) -{ - container.emplace_back(); - return container.back(); -} /// convenience erasor for unordered maps: std::erase_if(std::unordered_map) is C++20 template void for_all_in_map_erase_if(std::unordered_map &map_inout, PredT predicate)