Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-12-11 01:21:28 +09:00
Code Issues Packages Projects Releases Wiki Activity

p2p: unpack memory layout of peerlist entries

Browse Source 
The `#pragma pack(push, 1)` directive was causing unaligned memory
accesses to shared pointers in `epee::net_utils::network_address`.
The peerlist file uses Boost serialization, so this should be
backwards compatible.
This commit is contained in:
jeffro256 2025-11-05 15:30:48 -06:00
parent 6bb36309d6
commit acda1d4a37
No known key found for this signature in database
GPG Key ID: 6F79797A6E392442
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/p2p/p2p_protocol_defs.h
View File

@ -54,8 +54,6 @@ namespace nodetool
s << std::hex << peer_id; s << std::hex << peer_id;
return epee::string_tools::pad_string(s.str(), 16, '0', true); return epee::string_tools::pad_string(s.str(), 16, '0', true);
} }
#pragma pack (push, 1)
template<typename AddressType> template<typename AddressType>
struct peerlist_entry_base struct peerlist_entry_base
@ -108,8 +106,6 @@ namespace nodetool
}; };
typedef anchor_peerlist_entry_base<epee::net_utils::network_address> anchor_peerlist_entry; typedef anchor_peerlist_entry_base<epee::net_utils::network_address> anchor_peerlist_entry;
#pragma pack(pop)
inline inline
std::string print_peerlist_to_string(const std::vector<peerlist_entry>& pl) std::string print_peerlist_to_string(const std::vector<peerlist_entry>& pl)
{ {