Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-12-11 01:21:28 +09:00
Code Issues Packages Projects Releases Wiki Activity

epee: align container pod as blob serialization

Browse Source 
`{un}serialize_stl_container_pod_val_as_blob()` use aligned memory accesses on potentially unaligned pointers.
This commit is contained in:
jeffro256 2025-10-14 15:51:35 -05:00
parent b591866fcf
commit ece0342cb5
No known key found for this signature in database
GPG Key ID: 6F79797A6E392442
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
contrib/epee/include/serialization/keyvalue_serialization_overloads.h
View File

@ -117,11 +117,11 @@ namespace epee
if(!container.size()) return true;
std::string mb;
mb.resize(sizeof(typename stl_container::value_type)*container.size());
typename stl_container::value_type* p_elem = (typename stl_container::value_type*)mb.data();
char *p_elem = mb.data();
BOOST_FOREACH(const typename stl_container::value_type& v, container)
{
*p_elem = v;
p_elem++;
memcpy(p_elem, std::addressof(v), sizeof(typename stl_container::value_type));
p_elem += sizeof(typename stl_container::value_type);
}
return stg.set_value(pname, std::move(mb), hparent_section);
}
@ -135,14 +135,19 @@ namespace epee
if(res)
{
size_t loaded_size = buff.size();
typename stl_container::value_type* pelem = (typename stl_container::value_type*)buff.data();
char *pelem = buff.data();
CHECK_AND_ASSERT_MES(!(loaded_size%sizeof(typename stl_container::value_type)),
false,
"size in blob " << loaded_size << " not have not zero modulo for sizeof(value_type) = " << sizeof(typename stl_container::value_type) << ", type " << typeid(typename stl_container::value_type).name());
size_t count = (loaded_size/sizeof(typename stl_container::value_type));
hint_resize(container, count);
for(size_t i = 0; i < count; i++)
container.insert(container.end(), *(pelem++));
{
typename stl_container::value_type v;
memcpy(std::addressof(v), pelem, sizeof(v));
container.insert(container.end(), v);
pelem += sizeof(v);
}
}
return res;
}