Mirrors/pyenv
1
0
Fork 0
mirror of https://github.com/pyenv/pyenv.git synced 2026-10-02 23:41:06 +09:00
Code Issues Packages Projects Releases Wiki Activity

version-file: Fix infinite loop for relative paths

Browse Source 
find_local_version_file reduces its target with ${root%/*}, but that leaves a slash-less relative argument such as "." unchanged, leading to an infinite loop

Signed-off-by: 付典 <fudianchn@gmail.com>
This commit is contained in:
付典 2026-08-08 20:35:35 +03:00 committed by Ivan Pozdeev
parent b7e7adf4ec
commit 195b9fe940
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libexec/pyenv-version-file
View File

@ -8,6 +8,9 @@ target_dir="$1"
find_local_version_file() { find_local_version_file() {
local root="$1" local root="$1"
# Nonexistent paths are UB as of this writing.
# Relative ones cause a failure but absolute ones don't
[[ $root != /* ]] && root=$(CDPATH= cd -- "$root" && pwd)
while ! [[ "$root" =~ ^//[^/]*$ ]]; do while ! [[ "$root" =~ ^//[^/]*$ ]]; do
if [ -f "${root}/.python-version" ]; then if [ -f "${root}/.python-version" ]; then
echo "${root}/.python-version" echo "${root}/.python-version"

12
test/version-file.bats
View File

@ -73,3 +73,15 @@ create_file() {
run pyenv-version-file "$PWD" run pyenv-version-file "$PWD"
assert_failure "" assert_failure ""
} }
@test "walks up beyond cwd for a relative path" {
create_file ".python-version"
mkdir -p project/subdir
cd project
# Run with CPU-time limit because this used to loop forever
run bash -c 'ulimit -t 5; pyenv-version-file .'
assert_success "${PYENV_TEST_DIR}/.python-version"
run pyenv-version-file ./subdir
assert_success "${PYENV_TEST_DIR}/.python-version"
}